Template talk:S-line/Archive 1

This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request.

I'm working on reducing the backlog at

Not done: It's actually in Template:CR lines which is not protected. --Redrose64 (talk) 17:48, 6 January 2013 (UTC)

Thanks for pointing me in the right direction! GoingBatty (talk) 18:38, 6 January 2013 (UTC)

Can somebody please fix

Hi, I've taken care of this problem. You were editing the wrong template. This type of problem is fixed by editing the template Template:CRT stations. If you've touched any other templates, please revert your changes. And if you want you can also let me know and I'll help you deal with these or similar problems. But if you modify that template you modified in the way you did it, you'll break something else, so it's very important that other similar changes you've made are also reverted. Let me know if you need any help. Azylber (talk) 17:11, 4 May 2013 (UTC)

And by the way, this template system is used across all groups of articles on rail systems. Disambiguation is really easy because it's always done in the XXX stations template, where XXX is the code of the rail system. It has to be done that way to centralise the disambiguation for all the articles in the group. That XXX stations template is used by many other templates in that same system, and without these scheme it would be necessary to touch many templates just to disambiguate one thing. Hope this helps. Cheers, Azylber (talk) 17:16, 4 May 2013 (UTC)

Is there no way to set it up so that disambiguation can be effected with a simple |dab=(foo) parameter on the template that actually calls the link? bd2412 T 00:38, 5 May 2013 (UTC)

In my opinion, the current template scheme, that we have in thousands of pages about hundreds of rail systems, is the simplest way to do it. You just change the XXX stations template. I know what you're saying that disambiguators don't necessarily know this, but disambiguation is currently not a big issue at all in this wikiproject, I think we've got it pretty tight. Azylber (talk) 03:04, 5 May 2013 (UTC)

I don't think that it's necessary to show the disambiguator. See London Paddington station#Services, where in the "Following station" column of the routebox, there are five links to Edgware Road - but the Bakerloo Line one has a different target from the others. It's all handled through {{LUL stations}} - there is no special coding in {{S-line}}, {{S-line/side cell}}, {{S-line/LUL right/Bakerloo}}, {{S-line/LUL right/Circle}}, {{S-line/LUL right/District}} or {{S-line/LUL right/Hammersmith & City}}. There are, IIRC, three pairs of London Underground stations which have identical names but are on different lines (Edgware Road, Hammersmith and Shepherd's Bush), but only in the case of Edgware Road do both members of a pair have the same adjacent station. --Redrose64 (talk) 10:22, 5 May 2013 (UTC)

{{s-start}}
{{s-rail|title=Sydney Trains}}
{{s-line|system=Sydney Trains|line=Airport and East Hills|previous=Town Hall|next=Circular Quay}}
{{s-end}}
{{s-start}}
{{s-rail|title=Sydney Trains}}
{{s-line/sandbox|system=Sydney Trains|line=Airport and East Hills|previous=Town Hall|next=Circular Quay}}
{{s-end}}

checking Town Hall railway station, the link text is not white, even though there is a specific font declaration. I was going to address this within the {{Sydney Trains lines}} template, but the link text is used with both coloured and transparent backgrounds, so we cannot simply override the colouring. I thought that the issue can be resolved by changing the <font style="color:#..."> statements to <font color="#..."> statements, but it seems that doesn't work either. any suggestions? Frietjes (talk) 18:27, 11 August 2013 (UTC)

Template:Sydney Trains color defines both color and font color. Can something be done there? This looks like an overuse of color anyway. Most other rail succession templates have simple bands of color and there is no conflict within the text box. Sw2nd (talk) 18:46, 11 August 2013 (UTC)

Normal display is mimiced below. How do they get all that color block and border? Sw2nd (talk) 19:08, 11 August 2013 (UTC)

{{s-start}}
{{s-rail|title=Sydney Trains}}
{{rail line|previous=[[Town Hall railway station|Town Hall]]<br><small>''towards Central''</small>|next=[[Circular Quay railway station|Circular Quay]]<br><small>''towards Macarthur''</small>|route=[[Airport and East Hills railway line|Airport and East Hills Line]] |col={{Sydney Trains color|airport and east hills}} }}
{{s-end}}

Some months ago (see

WP:CONTRAST concerns (compare with old version), including the requirement that "Links should clearly be identifiable as a link to our readers". --Redrose64 (talk

) 19:24, 11 August 2013 (UTC)

Got it! Change the definition in Template:Sydney Trains lines to include the small text. Sw2nd (talk) 15:40, 12 August 2013 (UTC)

Tried to set up Eurocity as a system under this template family. It mostly seems to have worked, but the newly created Template:S-line/EC left/ and Template:S-line/EC right/ don't seem to be working correctly, despite being exact copies of Template:S-line/SBB-CFF-FFS left/ and Template:S-line/SBB-CFF-FFS right/. In fact, they come as redlinks, even though you can successfully follow them. You can see the resulting effect in the infobox at Lugano railway station. Can anybody point out what I've done wrong?. -- chris_j_wood (talk) 13:54, 30 October 2013 (UTC)

Well, I don't understand that. After 3 or 4 hours, it seems to have sorted itself out. Some sort of caching issue?. -- chris_j_wood (talk) 15:17, 30 October 2013 (UTC)

Resolved

There appears to be an typo in the template for the preceding station or following station of

The {{s-line}} templates are a real pain in the ass to trace through. This edit should fix it; please reply if not. --Redrose64 (talk) 21:54, 28 January 2014 (UTC)

Great! That took care of it! Thanks!

talk

) 22:58, 28 January 2014 (UTC)

just fixed a bug when hidemid=y and hide2=y which results in spurious blank lines since the inner cells are not rendered. I also updated the testcases to expose such bugs (added some text above and below the succession box make the spurious newlines more obvious). Frietjes (talk) 15:49, 21 May 2014 (UTC)

This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request.

Merge the contents of the /sandbox (inside the <includeonly> tags) into the main template. This, as shown inside the infoboxes on the testcases page, fixes the display problem inside infobox tables where the infobox CSS class overrides the CSS of the <tr> tag—each table cell now has the text-align: center declaration. Jc86035 (talk • contribs) Use {{re|Jc86035}} to reply to me 08:22, 24 June 2015 (UTC)

It's not such a big issue with this one, so let's just wait for it to be fixed in the stylesheet.

talk

) 14:07, 24 June 2015 (UTC)

@Alakzi: Is the stylesheet going to be fixed, though? Jc86035 (talk • contribs) Use {{re|Jc86035}} to reply to me 14:40, 26 June 2015 (UTC)

Flip a coin.

talk

) 14:41, 26 June 2015 (UTC)

Done

talk

) 14:43, 26 June 2015 (UTC)

Hi, still quite unsure about how to add a different terminus station for branch lines for the same main line after reading the main article on s-line. Such example can be seen at

The whole s-line system seriously overuses subtemplates. In this case, it's either {{S-line/SRT right/Southern}} or {{SRT stations}} that needs fixing. --Redrose64 (talk) 09:24, 4 July 2016 (UTC)

If you look at Special:WantedTemplates, you can see that many of the nonexistent templates listed are "XXX style" templates that are called by rail articles, specifically those that use {{S-line}} and similar templates. I have updated {{S-line}} in an attempt to test for the existence of these "system style" templates before calling them, but I have been unsuccessful so far. As far as I know, I have not broken the template, but if anyone can provide any insight as to why S-line is still calling nonexistent templates, I would be grateful. I'd like to get these style templates off of the WantedTemplates list so that it is easier to see other problems on the list.

An example page that calls a nonexistent style template is

@Jonesey95: Maybe {{S-line/side cell}}, though I think adding more ifexist functions might make the template less efficient. (At some point it might be better to change S-line to use module subpages like {{Location map}}, so all the info for a system could be stored on one page.) Jc86035 (talk) Use {{re|Jc86035}}
to reply to me 02:55, 15 October 2016 (UTC)

Yes, I think you're right. We need another {{#ifexist:Template:{{{system}}} style| test before the {{#ifeq:{{{{{system}}} style|showterm}}|No ifeq statement. I have played a bit in the sandbox, but I haven't figured out the impressively nested if statements well enough to figure out where to put it and still show the text that we want to show. I have calls to the sandbox code for S-line and S-line/side cell in User:Jonesey95/sandbox3 if anyone wants to experiment with S-line/side cell and see what the results look like.

I feel like I'm always asking Frietjes for help, so don't feel like you have to help here, but I think you might be able to fix this one. – Jonesey95 (talk) 04:58, 15 October 2016 (UTC)

added an extra #ifexist. I tested it in the sandbox first, and the testcases showed no problems, so I updated the main template as well. Frietjes (talk) 19:47, 15 October 2016 (UTC)

{{

#ifexist}} is horribly expensive, and should be used sparingly. --Redrose64 (talk

) 20:10, 15 October 2016 (UTC)

true. we could refactor it to reduce from two to one call by moving it up a few levels in the nested parserfunctions, or rewrite it in lua to have even more control over the number of #ifexist calls. Frietjes (talk) 21:48, 15 October 2016 (UTC)

It looks like that worked. Template:IT-Treno_regionale_style was being called by 236 articles, and after null edits of the articles transcluding it, that number is down to zero. The template is still being linked from a pile of articles, but that doesn't seem to cause any problems. – Jonesey95 (talk) 00:14, 16 October 2016 (UTC)

yes, the #ifexist effectively changes the transclusions to links. there is no easy way, as far as I can tell, to completely eliminate everything in "what links here". Frietjes (talk) 14:21, 16 October 2016 (UTC)

The documentation here needs to address non-uniform cases! Examples of only "uniform" cases are given, please add a non-uniform example. Or otherwise give a clue about how to handle when a station name is ambiguous, when disambiguation is needed. Searching the documentation for "ambig" gives three items about state1, state2 stuff, but that is no help in my case. Also there are no instances of "pipe" in the document, when I thought pipelinking would be needed.

My problem was that at

{{s-rail-start}}
{{s-rail|title=TRA}}
{{s-line|system=TRA|line=Western|previous=Zhongli|next=Yangmei}}
{{end}}
{{TRA Western Line}}

Seeing that code, i came to template:s-line to see what I should change in the template call. I eventually figured out how to fix the problem, but only from reading 2013 discussion raised by BD2412 above, at #Template:S-line/CRT right/1.

The fix was:

• 0. make NO CHANGE in the s-line template call. So for me, at
  Puxin Station
  article, I needed to restore the "s-line" statement back to how it was originally, before I made reasonable tries like replacing "Yangmei" by "Yangmei (Taiwan)" or by "Yangmei Station (Taiwan)|Yangmei".
• 1. take a leap and assume that there exists a Template:TRA stations, despite there being no link to any such template at the Puxin Station article(!!!!)
• 2. despite the template showing nothing understandable, go ahead and edit it. When in edit mode I could see other examples luckily, and following them I figured I should add a line:

| Yangmei=[[Yangmei Station (Taiwan)|Yangmei]]

Some text like here should be added to the documentation I think, perhaps in Q&A form to answer the question "What if a station name is ambiguous? Should pipelinking be used?", being sure to use terms pipelink and disambiguation.

Hope this could possibly help someone else. --doncram 13:11, 7 August 2015 (UTC)

You still did not direct to the correct article in Template:TRA stations. Secondarywaltz (talk) 14:33, 7 August 2015 (UTC)

Yep, it was supposed to be the Taiwan one, i.e.

| Yangmei=[[Yangmei Station (Taiwan)|Yangmei]] . Thanks for catching and fixing that. --doncram 18:06, 7 August 2015 (UTC)

I'm trying to disambiguate an S-line template for Roseville railway station, Sydney which is called from Chatswood railway station. The template points to the disambiguation page Roseville station. Based on what I think I'm reading above, I tried to edit Template:Sydney Trains stations by adding a line "Roseville = [[Roseville railway station, Sydney|Roseville]]" but it seemed to have no effect, so I reverted my edits to the template. Can somebody 'in the know' please look into this and advise on how to disambiguate the link? Thanks in advance! PKT(alk) 23:33, 24 November 2016 (UTC)

I reverted this edit because I could see no problem. What was wrong with it? --Redrose64 (talk) 00:12, 25 November 2016 (UTC)

Wow! - when I tried it and tested the edit, it didn't seem to work..... but it does now. Maybe I should have allowed more time for the template edit to take effect? I dunno, but thank you for checking!! PKT(alk) 01:14, 25 November 2016 (UTC)

Hi, I added the train service type parameter, {{servicetype|}}, and the secondary color parameter, {{2rycol|}} so that you could disambiguate the train service types other than local/stopping service with an optional horizontal color band. The below succession boxes are examples what I applied to.

The reason for the amendment is the current S-line template is not assumed to multiple train services within a short-hauled line/route. For more than a half century, Japanese commuter railways have adopted color systems for their train service types such as Express or Rapid Express, rather than adopting colors for their rail lines/routes.

Hope you understand my intention and this modification helps the S-line template more universal. Thanks – KU (talk) 10:55, 20 August 2016 (UTC)

{{s-rail-start}}
{{s-rail|title=Kintetsu}}
{{s-line/sandbox|system=Kintetsu|line=Kyoto/Kashihara|service=Local|previous=Unebigoryōmae|next=|type=Nishinokyo—Kashiharajingu-mae|type2=Hirahata—Unebigoryomae|rows2=3}}
{{s-line/sandbox|system=Kintetsu|line=Kyoto/Kashihara|service=Express|previous=Unebigoryōmae|type=Nishinokyo—Kashiharajingu-mae2|type2=Hirahata—Unebigoryomae|hide2=yes}}
{{s-line/sandbox|system=Kintetsu|line=Kyoto/Kashihara|service=Limited Express|previous=Yamato-Yagi|type=Nishinokyo—Kashiharajingu-mae2|type2=Nishinokyo—Yamato-Yagi|hide2=yes}}
{{s-line/sandbox|system=Kintetsu|line=Minami-Osaka/Yoshino|service=Local|previous=Kashiharajingū-nishiguchi|next=Okadera|type=Takadashi—Kashiharajingu-mae|type2=Kashiharajingu-nishiguchi—Kashiharajingu-mae|rows1=2|rowsmid=3}}
{{s-line/sandbox|system=Kintetsu|line=Minami-Osaka/Yoshino|service=Local|next=|type=Takadashi—Kashiharajingu-mae|type2=|hide1=yes|hidemid=yes}}
{{s-line/sandbox|system=Kintetsu|line=Minami-Osaka/Yoshino|service=Local|previous=|next=Okadera|type=Takadashi—Kashiharajingu-mae|type2=Kashiharajingu-mae—Okadera|hidemid=yes}}
{{s-line/sandbox|system=Kintetsu|line=Minami-Osaka/Yoshino|service=Semi-express|previous=Kashiharajingū-nishiguchi|next=Okadera|type=Takadashi—Kashiharajingu-mae|type2=Kashiharajingu-mae—Yoshinojingu|rows1=3|rowsmid=2}}
{{s-line/sandbox|system=Kintetsu|line=Minami-Osaka/Yoshino|service=Semi-express|next=|type=Takadashi—Kashiharajingu-mae|type2=|hide1=yes|hidemid=yes}}
{{s-line/sandbox|system=Kintetsu|line=Minami-Osaka/Yoshino|service=Suburban Express|next=|type=Osaka-Abenobashi—Takadashi|type2=|hide1=yes}}
{{s-line/sandbox|system=Kintetsu|line=Minami-Osaka/Yoshino|service=Express|previous=Takadashi|next=Okadera|type=Furuichi—Yoshino|type2=Kashiharajingu-mae—Yoshinojingu|rows1=4|rowsmid=2}}
{{s-line/sandbox|system=Kintetsu|line=Minami-Osaka/Yoshino|service=Express|next=|type=Furuichi—Yoshino|type2=|hide1=yes|hidemid=yes}}
{{s-line/sandbox|system=Kintetsu|line=Minami-Osaka/Yoshino|service=Limited Express|next=Asuka|type=Furuichi—Yoshino|type2=Osaka-Abenobashi—Yoshinojingu|hide1=yes|rows2=2}}
{{s-line/sandbox|system=Kintetsu|line=Sakura Liner|service=Limited Express|type=Furuichi—Yoshino|type2=Osaka-Abenobashi—Yoshinojingu|hide1=yes|hide2=yes}}
{{end}}

The point about the {{s-line}} group is that you don't use parameters to specify colours, it's all pulled from the system-specific subtemplates. So I think that this is the wrong approach. Regarding how it should be done, I already did this three years ago for National Rail:

Preceding station	National Rail			Following station
Terminus		Abellio ScotRail Glasgow South Western Line		MetroCentre

see this edit and this one. --Redrose64 (talk) 11:49, 20 August 2016 (UTC)

I recognize your smart applications to the NR a few year ago, actually, I tried to refer to those. But your line color (lightcol) stripe practice with <div>~</div> look neat and nice, but not at all when heights of succession boxes is more than two sentense lines. As you may know, lengths of station and line names are relatively long unlike the NR. Besides, the method changing around {{{branch}}} on S-line subpage template for each railway system does not seem practical since there are over 180 rail transit operators even in Japan. That's another reason why I decided to modify the S-line template itself. Hope you undertand the situation. As of parameters to specify colors, it seems to be improved, thanks to Jc86035. Anyway, thanks for your pointing out. KU (talk) 01:27, 21 August 2016 (UTC)

@KU: (edit conflict) Looks nice; could be useful for other complicated systems like the NYC subway. I've modified the template sandbox (and {{Kintetsu color}}) so that |servicetype= is now |service=, and the colour can now be called from Template:[system] color instead of having to be manually entered (this replaces |2rycol=). Jc86035 (talk • contribs) Use {{re|Jc86035}} to reply to me 11:32, 20 August 2016 (UTC)

Thanks for improving the sandbox template and its subpage template. I appreciate it. KU (talk) 01:27, 21 August 2016 (UTC)

Would someone, with an administrator status who agree with this amendment, copy the S-line/sandbox, except for the sandbox notice at the bottom, into the live S-line template? Thanks in advance. KU (talk) 07:24, 28 August 2016 (UTC)

@

Edit protected}} if you want this added; also, the documentation should be updated to reflect the changes. Jc86035 (talk) Use {{re

|Jc86035}}
to reply to me 14:21, 25 September 2016 (UTC)

@Jc86035: Would you submit the current S-line/sandbox content to the live S-line template if you agree the amendment since I had been not granted as neither a template editor nor an administrator. Thanks KU (talk) 22:51, 26 September 2016 (UTC)

@KU: Sorry, I can't do that either. Jc86035 (talk) Use {{re|Jc86035}}
to reply to me 04:30, 27 September 2016 (UTC)

@Redrose64 and KU: Would there be any potential problems with conflicts if the proposed service colours were called with {{{service}}} instead of {{{line}}}~~{{{service}}}? Jc86035 (talk) Use {{re|Jc86035}}
to reply to me 11:42, 10 January 2017 (UTC)

Wangjiawan Station is now a disambiguation page. Please make whatever adjustments are needed to the following articles to allow the links to point to the correct station:

• Zongguan Station
• Yulong Road Station
• Shilipu Station (Wuhan)
• Line 3, Wuhan Metro
• Jiangwangmiao Station

Cheers! bd2412 T 04:17, 10 March 2017 (UTC)

@BD2412:  Done by editing Template:WHM stations. Jc86035 (talk) Use {{re|Jc86035}}
to reply to me 04:46, 10 March 2017 (UTC)

• Thanks. I made the same edit (with the other disambiguator) on Template:NJM stations to fix the last link. Cheers! bd2412 T 05:02, 10 March 2017 (UTC)

I don't get it about colors you did not give the instruction of creating color but first how to create color for example red blue green Armanjarrettp (talk) 13:32, 28 August 2017 (UTC)

@Armanjarrettp: Do you not understand how web colors are encoded, or do you not know how to create a Template:«system» color template? Jc86035 (talk) 15:29, 28 August 2017 (UTC)

There was a problem! on this template | services= there was a name "Santa Fe Southern Railway to Santa Fe" on service infobox how to fix this?

Here this sample check the service

@Armanjarrettp: What are you trying to do? I cannot understand what you're saying. (Please sign with four tildes ~~~~.)

[[Santa Fe Southern Railway]] to [[Santa Fe Depot (Rail Runner station)|Santa Fe]] is in the code of the template. Did you add it? Are you trying to use {{S-line}} with it? Do you want to remove it? Jc86035 (talk) 16:11, 2 September 2017 (UTC)

What happend this template?

first i created this <code>Los Angeles</noinclude>[[Category:Atchison, Topeka and Santa Fe Railway templates]]</noinclude></code> lated on i have many times to edit this but is not work to toward right. Whats happend it is blocked?

{{s-start}}
{{s-line|system=ATSF|line=Golden Gate|previous=Holt|next=Burnham}}
{{s-end}}

— Preceding unsigned comment added by Armanjarrettp (talk • contribs) 22:59, 3 September 2017 (UTC)

@Armanjarrettp: You used two closing tags </noinclude> where you should have used one opening tag <noinclude> and one closing tag </noinclude>. --Redrose64 🌹 (talk) 06:42, 4 September 2017 (UTC)

This edit broke the S-line template. How can that be remedied? Andy Mabbett (Pigsonthewing); Talk to Andy; Andy's edits 21:57, 19 October 2017 (UTC)

@Pigsonthewing: The |system= parameter doesn't expect the value to contain markup of any kind, not even links. This is because it's used to build a template or subtemplate name, and page names cannot contain markup. So, in the previous version, the parameter |system=Avant caused the invocation of these subtemplates: {{Avant color}}; {{Avant lines}}; {{Avant stations}}; {{S-line/Avant left/}}; and {{S-line/Avant right/}}. --Redrose64 🌹 (talk) 22:18, 19 October 2017 (UTC)

See

I removed the custom NSW styling yesterday. Jc86035 (talk) 13:23, 4 November 2017 (UTC)

Hello, I suggest that two new columns shall be added to the template : Origin and Destination. It will give more information, as in the French Wikitemplate https://fr.wikipedia.org/wiki/Mod%C3%A8le:Desserte_gare.

It will clarify the article containing the template, giving the sections of the line served by the line and company.

--Railfan01 (talk) 09:48, 5 November 2017 (UTC)

@Railfan01: This is already what the small text saying "toward[s] Terminus" does, so I don't think adding the columns is necessary or imparts additional information. Using the French Wikipedia layout would also make the table unnecessarily wide, especially where the template is used in infoboxes. Jc86035 (talk) 13:25, 5 November 2017 (UTC)

The {{

WP:SBS). Adding more columns would not fit in with that scheme. --Redrose64 🌹 (talk

) 15:29, 5 November 2017 (UTC)

-- Main module (proof-of-concept). Module:Arguments and basically everything omitted for clarity, so this will basically only return a station name based on a data page
local p = {}

function p.findStation(frame)

	local args = frame.args
	-- System would be handled differently in a module allowing multiple systems and would be loaded somewhere else before being used by this function
	local data = mw.loadData('Module:S-line/data/'..args.system)
	-- Since there's only one variable here mw.ustring.gsub might be better?
	local link = data.stations[args.station] or string.format(data.stations['#default'], args.station, args.station)
	return link
end

return p

-- Data subpage. No aliases table for now
return {
	lines = {
		['Main line'] = {
			color = '#C35617',
			link = '[[Taiwan High Speed Rail]]',
			left = 'Nangang',
			right = 'Zuoying',
		},
	},
	stations = {
		['#default'] = '[[%s HSR station|%s]]',
		['Taipei'] = '[[Taipei station|Taipei]]',
	},
}

@Narky Blert: As the documentation says, you can fix this by editing the "stations" succession template; in this case {{Transperth stations}}. Jc86035 (talk) 03:02, 18 January 2018 (UTC)

@

dn

}} tags into the |previous= and |next= parameters, this breaks the linking horribly.

If the station that is to be linked to has parenthetical disambiguation, the |state1= and |state2= parameters of {{s-line}} may normally be used (without the parentheses) to supply that disambiguation. In this case, comma disambiguation is employed, and the actual fix was to this subtemplate. --Redrose64 🌹 (talk) 10:56, 18 January 2018 (UTC)

It would be preferable to improve the {{S-line}} template itself with a common parameter like "dab=" so that editors do not need to hunt down other templates to fix. New articles on stations are written every week, rendering existing station names ambiguous. bd2412 T 12:16, 18 January 2018 (UTC)

It already has such parameters, |state1= and |state2=. --Redrose64 🌹 (talk) 12:48, 18 January 2018 (UTC)

Can you add an example of a working use of those parameters to the template documentation? It is not clear where they need to go, or whether any other parameters need to be changed for their use. bd2412 T 15:04, 18 January 2018 (UTC)

They're named parameters; the positioning is immaterial. No other parameters need to be altered. Compare the following:

Preceding station		National Rail		Following station
Ashford		Test		Swinton
Swinton

They look identical, but the links differ. The values are passed by {{s-line}} through the |state= parameter of {{S-line/side cell}} into the |state= parameter of the relevant stations subtemplate which may then use the value in any way that might be appropriate. In this way, |state1= can modify the link generated by |previous=, and |state2= can modify the link generated by |next=, as shown above. --Redrose64 🌹 (talk) 21:54, 18 January 2018 (UTC)

I seem to recall having trouble making that work in the past, but I don't have a specific instance handy. I will try it going forward, and report back if there are any problems. bd2412 T 22:21, 18 January 2018 (UTC)

"state1, state2 Allows the passing of an additional station parameter. Useful for disambiguation."

To what? The documentation doesn't say.

Perth isn't a state.

"Please don't put {{

dn

}} tags into the |previous= and |next= parameters, this breaks the linking horribly."

I am well aware that {{

dn}} tag outside a {{s-line

}} tag generates an unlocalised tag at the top of the article, with no guide to other disambiguators as to what the problem might be.

"As the documentation says, you can fix this by editing the "stations" succession template; in this case {{Transperth stations}}." Where was I supposed to have found that? I wasted 15 minutes of my life trying to solve the original problem, and am wasting more time now by posting here.

I suggest: new fields |previous-link= and |next-link=. A simple solution for any disambiguator faced with such problems, which would cope with both parenthetical and comma DABs. Narky Blert (talk) 23:40, 19 January 2018 (UTC)

I agree - it is always easiest to have a parameter that lets you put in the actual target link, so that exceptions to the usual naming scheme don't throw the template off. bd2412 T 00:39, 20 January 2018 (UTC)

Disambiguation of a station, the clue is in the phrase "additional station parameter".

Surrey isn't a state either.

Where have I come across links broken by {{

dn}} before? Ah, here

.

It's not difficult to see which subtemplates are used. First go to the problem article and open it up for edit, find the relevant template code, in this case it's

{{s-line|system=Transperth|line=Fremantle|previous=Cottesloe|next=Victoria Street}}

and copy it to your clipboard. Then go to

WP:SANDBOX, open it for edit, paste in that code and click Show preview. At the bottom there will be a list headed "Templates used in this preview" (which you may need to expand by clicking the right-pointing triangle), look for the word "stations" in this list and there is the link to Template:Transperth stations

.

If you feel that separate link parameters are necessary, it's probably better to use one of the {{rail line}} templates. Four parameters (three if it's a terminus, five if you want a horizontal coloured stripe in addition to the two vertical ones); no subtemplates. --Redrose64 🌹 (talk) 10:44, 20 January 2018 (UTC)

What about comma-DABs? See

North Main Corona station. I've discovered that it should be Arlington Station, California. Narky Blert (talk

) 18:45, 20 January 2018 (UTC)

Follow the instruction that I gave beginning "It's not difficult to see which subtemplates are used." Doing this, I find that it's Template:ATSF stations, hence, this edit.

The main problem with USA stations is that there is no consistent naming convention. --Redrose64 🌹 (talk) 22:17, 20 January 2018 (UTC)

Please tell me that you're having a laugh. I have no intention of learning the intricacies of how to disambiguate badly-written templates like this one.

WP:TDD, 20 January 2018: 10,911 bad links to DAB pages. You may just have reduced that number to 10,910. Narky Blert (talk

) 01:11, 21 January 2018 (UTC)

​It's not badly written; it's complicated because it was presumably designed to be able to handle all sorts of disambiguation and other quirks (like multiple line termini and links to non-stations) for the convenience of editors. If you ever decide to bother to find out how it works, all the information you need is in the documentation (I've linked the relevant section; only the first two subsections should matter for article disambiguation). Jc86035 (talk) 12:09, 21 January 2018 (UTC)

"for the convenience of editors". I have already told you. It is INconvenient for other, experienced, editors. Narky Blert (talk) 02:01, 22 January 2018 (UTC)

I agree. However complicated the template is, how hard can it be for seasoned template editors to add #IFEXIST parameters allowing a specific link to be designated in place of a disambiguation link for a given preceding parameter? All of this discussion could be spared if there was a way to put |link= (or maybe |link1=/|link2=) after the parameter containing the ambiguous term, and then add a ==Disambiguation links== section to the documentation that shows the wikitext to be implemented to make that fix. bd2412 T 02:07, 22 January 2018 (UTC)

I today came across another bad link to this template. Using the "helpful" instructions above, I managed to fix the problem in only about 10 minutes. Narky Blert (talk) 02:24, 23 January 2018 (UTC)

@Narky Blert and BD2412: I've added |link1= (left side) and |link2= (right side) for disambiguating links. Jc86035 (talk) 15:54, 26 January 2018 (UTC)

Many thanks! To be clear (for the documentation), we put the full text of the target link here, and it will override the previous parameter? bd2412 T 15:56, 26 January 2018 (UTC)

& documented them too - most helpful, thanks! Narky Blert (talk) 15:59, 26 January 2018 (UTC)

Perfect. bd2412 T 16:03, 26 January 2018 (UTC)

This edit request to Template:S-line has been answered. Set the |answered= or |ans= parameter to no to reactivate your request.

Please replace the following:

{{notice|This template is called by {{t1|s-rail-national}}; an alias. If a change is made which alters/adds parameters names that template must be updated to reflect the new situation.}}

With this:

{{notice|This template is called by {{tl|s-rail-national}}; an alias. If a change is made which alters/adds parameters names that template must be updated to reflect the new situation.}}

This is simply to correct a typo; "Template:T1" redirects to "Template:Tl" specifically because it is a common typo (confusing the letter "l" and the digit "1"), but the typo should still be fixed. Jdaloner (talk) 23:49, 17 April 2018 (UTC)

 Done I have moved the notice to the /doc subpage and corrected the error you identified — Martin (MSGJ · talk) 11:31, 18 April 2018 (UTC)

In Framingham station, this template generates a link to the DAB page Milford station. I cannot find how the link is being generated, let alone fix the problem. Narky Blert (talk) 07:47, 17 June 2018 (UTC)

@Narky Blert: Is the correct page Milford station (Connecticut)? (The template is {{NYC stations}}.) Jc86035 (talk) 07:53, 17 June 2018 (UTC)

@Jc86035: As far as I can tell, it should be Milford station (Massachusetts). See Milford Branch. Narky Blert (talk) 07:58, 17 June 2018 (UTC)

@Narky Blert: @Anthonyt31201, Morphenniel, and Pi.1415926535: Is the row correct, and should it actually be in the article? The diagram in Milford Branch indicates that the branch did not have any passenger stations, and that the station labelled "Milford Depot" (red link) was on the Milford Secondary – but I don't know anything about these lines other than what's in the articles, and they don't make this clear. Jc86035 (talk) 08:07, 17 June 2018 (UTC)

Yes, Milford Secondary shows that the Milford branch bypassed Milford Depot (no article) and joined the main line to run through Milford Yard (no article). Both are in Milford, Massachusetts. The fact that the terminus was in Milford is recorded in {{S-line/NYC left/Milford Branch}}. I've added a line to {{NYC stations}} to link Milford exceptionally to the town rather than to a station which was never built. That should fix it. No other pages seem to be affected. Certes (talk) 10:26, 17 June 2018 (UTC)

Milford had two stations - a wooden NYNH&H station on the Milford Secondary, and the still-extant stone B&A station on the Milford Branch. (The stations were about 150 feet apart; the lines met slightly to the south.) The latter lasted vastly longer (passenger service until 1959, versus 1920) and would be either Milford station (Massachusetts) or Milford station (Boston and Albany Railroad) should an article be created. (Note: I've created a Commons category: commons:Category:Milford station (Massachusetts)). I have corrected {{Milford Secondary}}, {{Milford Branch}}, and {{NYC stations}} to reflect this; however, the first two templates need a lot of work to include all former stations. Pi.1415926535 (talk) 19:41, 17 June 2018 (UTC)

To make my cryptic remarks above more explicit for anyone reading this section later:

1. View the article's source and identify the {{s-line|system=«S»|line=«L»|…}} template corresponding to the rogue link, noting «S» and «L».
2. View Template:S-line/«S» left/«L» or Template:S-line/«S» right/«L», depending which end of the line contains the link; the text should be a station abbreviation «A».
3. Edit Template:«S» stations, adding or updating the entry beginning with «A»=. (If appropriate, consider carefully updating a generic entry instead.)

In the example above, «S» is "MILW", «L» is "main" and «A» is "Seattle or Tacoma". Hope that helps, Certes (talk) 14:34, 7 August 2018 (UTC)

In

Fixed here. The offending link is the left end of a system=MILW row, so {{S-line/MILW left/main}} reveals which entry to change. Certes (talk) 13:17, 7 August 2018 (UTC)

Whoops, I remember noticing it on the page then never going back to fix it. Thanks Certes. —GFOLEY FOUR!— 21:31, 7 August 2018 (UTC)

The example under Transfers could be more accessible. The issue is that the heading of the first row, middle column, does not apply to the entire column. I believe this will cause screen readers to treat North London Line as if it were part of the London Overground.

{{s-start}}
{{s-rail|title=LUL}}
{{s-line|system=LUL|line=Jubilee|previous=West Hampstead|next=Swiss Cottage|type2=one}}
{{s-line|system=LUL|line=Metropolitan|previous=Wembley Park|next=Baker Street|type=Four|rowsmid=2|rows2=2}}
{{s-line|system=LUL|line=Metropolitan|previous=Harrow-on-the-Hill|type=Four|hidemid=yes|hide2=yes|note=Peak periods only}}
{{s-note|text=Out-of-system interchange}}
{{s-rail|title=LOG}}
{{s-line|system=LOG|line=North London|previous=West Hampstead|next=Hampstead Heath|transfer=Finchley Road & Frognal}}
{{s-end}}

I believe a more accessible example would be the following, for which the column heading for the middle column actually does apply to the entire column:

{{s-start}}
{{s-rail|title=Transport in London}}
{{s-rail-next|title=LUL}}
{{s-line|system=LUL|line=Jubilee|previous=West Hampstead|next=Swiss Cottage|type2=one}}
{{s-line|system=LUL|line=Metropolitan|previous=Wembley Park|next=Baker Street|type=Four|rowsmid=2|rows2=2}}
{{s-line|system=LUL|line=Metropolitan|previous=Harrow-on-the-Hill|type=Four|hidemid=yes|hide2=yes|note=Peak periods only}}
{{s-note|text=Out-of-system interchange}}
{{s-rail-next|title=LOG}}
{{s-line|system=LOG|line=North London|previous=West Hampstead|next=Hampstead Heath|transfer=Finchley Road & Frognal}}
{{s-end}}

Thisisnotatest (talk) 04:31, 13 March 2019 (UTC)

In Philippi station, this template is calling the DAB page Charleston station instead of Charleston station (West Virginia). Narky Blert (talk) 12:29, 20 August 2018 (UTC)

@Narky Blert: A tough one. That needs a new entry in {{B&O stations}} (insert |Charleston above |Wheeler…), but did the B&O use the rival C&O's Charleston station (West Virginia) or have a separate facility with no article, possibly on the other rail line north of the river? On a related note, I've retargetted Charleston station (Amtrak). Do you think we should change Charleston railway station (currently a redirect to Charleston, South Australia)? Certes (talk) 13:06, 20 August 2018 (UTC)

@Certes: IMO Charleston railway station should redirect to Charleston station as {{R from ambiguous term}}. I've cleaned up the incoming links, and added the Australian station to the DAB page. Yrs, Narky Blert (talk) 13:16, 20 August 2018 (UTC)

@Narky Blert: Thanks. After further investigation, I'm convinced that Charleston B&O was a separate station. The B&O took over the K&M and the Grafton – Charleston branch (formerly the Coal and Coke Railway). Both run north of the Kanawha river, with the C&O on the south bank (map) and I can find no record of a bridge. I've turned the dab into a redlink Charleston station (Baltimore and Ohio Railroad) by editing {{B&O stations}}. Certes (talk) 13:35, 20 August 2018 (UTC)

@Certes: Good work. I've retargetted Charleston railway station as proposed. Yrs, Narky Blert (talk) 13:38, 20 August 2018 (UTC)

@Narky Blert: A postcard for you from Charleston. The line north of the river still has a few sidings beneath the I-64, so that's probably the location. Certes (talk) 13:50, 20 August 2018 (UTC)

What we really need is a fast way to find the modules that generate these links. One way to do that would be to have a bot set up regular lists on the module talk page of all the links invoked in the module, so that if a link becomes ambiguous, an editor can just look for "Module talk" links on the "What links here" page to figure out which module needs to be changed to fix the link. bd2412 T 13:08, 13 March 2019 (UTC)

Wikipedia:Disambiguation pages with links/Guide#Railway stations has some tips for playing Hunt the Module. Certes (talk) 13:21, 13 March 2019 (UTC)